Fix missing prettyPrint overloads in header and implementation#2209
Open
ActualMasterOogway wants to merge 1 commit intoluau-lang:masterfrom
Open
Fix missing prettyPrint overloads in header and implementation#2209ActualMasterOogway wants to merge 1 commit intoluau-lang:masterfrom
prettyPrint overloads in header and implementation#2209ActualMasterOogway wants to merge 1 commit intoluau-lang:masterfrom
Conversation
Exposed the prettyPrint overload that accepts CstNodeMap in the header and added a corresponding unit test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a discrepancy between
Ast/include/Luau/PrettyPrinter.handAst/src/PrettyPrinter.cpp.The header declared
std::string prettyPrint(AstStatBlock& ast);but the implementation was missing.The implementation had
std::string prettyPrint(AstStatBlock& block, const CstNodeMap& cstNodeMap)but it was not declared in the header.Changes:
std::string prettyPrint(AstStatBlock& block, const CstNodeMap& cstNodeMap);toPrettyPrinter.h.std::string prettyPrint(AstStatBlock& block)inPrettyPrinter.cpp(delegating to the 2-arg version).prettyPrint(AstStatBlock&)works correctly.Fixes #2206